Fix renaming a dimension in aggregations #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
force-pushed
the
rename-dim-agg
branch
from
d18051c
to
c23e2dd
Compare
tdrwenski
changed the title
tdrwenski
force-pushed
the
rename-dim-agg
branch
from
c23e2dd
to
26ee658
Compare
| @@ -810,9 +810,11 @@ private void readDim(Group.Builder groupBuilder, @Nullable Group refGroup, Eleme | |||
|
|
|||
| String nameInFile = dimElem.getAttributeValue("orgName") != null ? dimElem.getAttributeValue("orgName") : name; | |||
|
|
|||
| // LOOK this is wrong, groupBuilder may already have the dimension. | |||
haileyajohnson
approved these changes
Apr 15, 2024
tdrwenski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Renaming an aggregation dimension using NcML does not work-- it will throw an exception in the case of an aggregation with a scan element (see Unidata/tds#490) and have the wrong size in the case of an aggregation with locations. The aggregation dimension is already part of the
groupBuilder, so we need to use that instead of therefGroup(which is the dimension from a single file, or null in the case of a scan), in order to treat it as an existing dimension instead of a new one.